Skip to content

remove sorting of bool values since torch 2.4 does not support it on cuda - #731

Merged
kiddyjinjin merged 1 commit into
flagos-ai:masterfrom
iclementine:sort
Jul 3, 2025
Merged

remove sorting of bool values since torch 2.4 does not support it on cuda#731
kiddyjinjin merged 1 commit into
flagos-ai:masterfrom
iclementine:sort

Conversation

@iclementine

Copy link
Copy Markdown
Contributor

PR Category

Benchmark

Type of Change

Other

Description

remove sorting of bool values since torch 2.4 does not support it on cuda

Issue

Progress

  • Change is properly reviewed (1 reviewer required, 2 recommended).
  • Change is responded to an issue.
  • Change is fully covered by a UT.

Performance

@StrongSpoon StrongSpoon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kiddyjinjin
kiddyjinjin merged commit 4d205bc into flagos-ai:master Jul 3, 2025
9 of 14 checks passed
@iclementine
iclementine deleted the sort branch July 4, 2025 05:46
nicelynice pushed a commit to nicelynice/FlagGems that referenced this pull request Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants