[AdvancedCompiler]Cat(cpp wrapper) - #733
Merged
Merged
Conversation
StrongSpoon
reviewed
Jul 7, 2025
StrongSpoon
left a comment
StrongSpoon
left a comment
Collaborator
There was a problem hiding this comment.
Tests are very comprehensive and can be extended to python ut.
StrongSpoon
reviewed
Jul 8, 2025
| FetchContent_Declare(TritonJIT | ||
| GIT_REPOSITORY https://github.com/iclementine/libtorch_example.git | ||
| GIT_REPOSITORY git@github.com:AdvancedCompiler/libtriton_jit.git | ||
| # GIT_REPOSITORY https://github.com/iclementine/libtorch_example.git |
Collaborator
There was a problem hiding this comment.
I suggest using the original repository. If any code changes are made, please create a pull request to libtorch_example.
Collaborator
There was a problem hiding this comment.
Thanks for the review . Downloaded from advancedcompiler due to permission issues; no modifications were made to libtriton_jit. Fixed. : )
meinie0826
approved these changes
Jul 9, 2025
nicelynice
pushed a commit
to nicelynice/FlagGems
that referenced
this pull request
Feb 24, 2026
* updata cat cpp wrapper * fix CMakelist.txt * fix PR733 cat cpp wrapper review * fix /CMakeLists.txt --------- Co-authored-by: Ea760 <15236119052@163.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
New Feature
Description
CPP wrapper packaging for cat op.
Issue
Progress
Performance