[AdvancedCompiler]bmm(cpp wrapper) - #735
Merged
Merged
Conversation
iclementine
reviewed
Jul 3, 2025
| namespace flag_gems { | ||
| using namespace triton_jit; | ||
|
|
||
| at::Tensor bmm(at::Tensor& A, at::Tensor& B) { |
Contributor
There was a problem hiding this comment.
Use constant reference to values that does not need mutation.
iclementine
reviewed
Jul 3, 2025
| m.def( | ||
| "rotary_embedding(Tensor q, Tensor k, Tensor cos, Tensor sin, Tensor? position_ids=None, " | ||
| "bool rotary_interleaved=False) -> (Tensor, Tensor)"); // q and k may be view to other size | ||
| m.def("bmm(Tensor A, Tensor B) -> Tensor"); |
Contributor
There was a problem hiding this comment.
Please refer to torch's op schema lang for more details about relation of the schema here and the function signature of c++ function.
iclementine
suggested changes
Jul 3, 2025
iclementine
left a comment
iclementine
left a comment
Contributor
There was a problem hiding this comment.
Use const reference for Tensors that do not need mutation.
nicelynice
pushed a commit
to nicelynice/FlagGems
that referenced
this pull request
Feb 24, 2026
* Update the C++ wrapper for bmm * Modify the BMM code according to the review comments --------- Co-authored-by: “ph0375” <“ph0375@163.com”>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
New Feature
Description
CPP wrapper packaging for bmm op.
Issue
Progress
Performance