[AdvancedCompiler]Topk(cpp wrapper) - #736
Merged
StrongSpoon merged 6 commits intoJul 16, 2025
Merged
Conversation
Bowen12992
reviewed
Jul 15, 2025
Comment on lines
+16
to
+18
| if (dim < 0) { | ||
| dim = x.dim() + dim; | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (dim < 0) { | |
| dim = x.dim() + dim; | |
| } | |
| dim = dim < 0 ? x.dim() + dim : dim; |
Bowen12992
reviewed
Jul 15, 2025
Comment on lines
+50
to
+58
| /*def topk_stage1_kernel( | ||
| y_ptr, | ||
| index_ptr, | ||
| x_ptr, | ||
| k, | ||
| N: tl.constexpr, | ||
| CHUNK_SIZE: tl.constexpr, | ||
| DESCENDING: tl.constexpr, | ||
| ):*/ |
Collaborator
There was a problem hiding this comment.
Suggested change
| /*def topk_stage1_kernel( | |
| y_ptr, | |
| index_ptr, | |
| x_ptr, | |
| k, | |
| N: tl.constexpr, | |
| CHUNK_SIZE: tl.constexpr, | |
| DESCENDING: tl.constexpr, | |
| ):*/ | |
| /* | |
| def topk_stage1_kernel(y_ptr, | |
| index_ptr, | |
| x_ptr, | |
| k, | |
| N: tl.constexpr, | |
| CHUNK_SIZE: tl.constexpr, | |
| DESCENDING: tl.constexpr): | |
| */ |
Bowen12992
reviewed
Jul 15, 2025
Comment on lines
+72
to
+82
| /*def topk_stage2_kernel( | ||
| y_ptr, | ||
| index_ptr, | ||
| chunk_x, | ||
| chunk_index, | ||
| sort_dim: tl.constexpr, | ||
| k: tl.constexpr, | ||
| N: tl.constexpr, | ||
| BLOCK_SIZE: tl.constexpr, | ||
| DESCENDING: tl.constexpr, | ||
| ):*/ |
StrongSpoon
reviewed
Jul 16, 2025
nicelynice
pushed a commit
to nicelynice/FlagGems
that referenced
this pull request
Feb 24, 2026
* merge * Change the format * Rename test_triton_special.cpp to test_triton_topk.cpp * change to test_triton_topk --------- Co-authored-by: nmpress1 <1935298275@qq.com> Co-authored-by: nmpress1 <162261334+nmpress1@users.noreply.github.com> Co-authored-by: StrongSpoon <35829812+StrongSpoon@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Category
Operator
Type of Change
New Feature
Description
CPP wrapper packaging for topk op.
Issue
Progress
Performance