Skip to content

fix: remove copyright headers from results_gold data files - #1242

Merged
Caozhou1995 merged 3 commits into
flagos-ai:mainfrom
tengqm:remove-copyright-results-gold
Jul 24, 2026
Merged

fix: remove copyright headers from results_gold data files#1242
Caozhou1995 merged 3 commits into
flagos-ai:mainfrom
tengqm:remove-copyright-results-gold

Conversation

@tengqm

@tengqm tengqm commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

These data files are compared against test outputs line-by-line and cannot contain license headers — adding them broke CI functional tests (e.g., inference/qwen3/4b_tp2).

Files fixed (7)

File
inference/deepseek_r1_distill_qwen/results_gold/7b_tp2
inference/deepseek_r1_distill_qwen_flaggems/results_gold/7b_tp2
inference/qwen3/results_gold/4b_tp2
inference/qwen3/results_gold/4b_tp2_ascend
inference/qwen3_flaggems/results_gold/4b_tp2
inference/robobrain2/results_gold/7b_tp2
inference/robobrain2_flaggems/results_gold/7b_tp2

The one JSON gold file (rl/qwen2_5/results_gold/0_5b.json) was not affected — JSON doesn't support comments so the header was never added there.

Closes #1241's inference test failure.

tengqm and others added 2 commits July 20, 2026 17:02
These data files are compared against test outputs and cannot contain
license headers — adding them broke CI functional tests.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@zhaoyinglia zhaoyinglia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Caozhou1995
Caozhou1995 merged commit 7d08c73 into flagos-ai:main Jul 24, 2026
56 of 58 checks passed
@tengqm
tengqm deleted the remove-copyright-results-gold branch July 24, 2026 08:42
LiJunscs pushed a commit to LiJunscs/FlagScale that referenced this pull request Jul 27, 2026
…#1242)

These data files are compared against test outputs line-by-line and
cannot contain license headers — adding them broke CI functional tests
(e.g., inference/qwen3/4b_tp2).

## Files fixed (7)

| File | 
|---|
| inference/deepseek_r1_distill_qwen/results_gold/7b_tp2 |
| inference/deepseek_r1_distill_qwen_flaggems/results_gold/7b_tp2 |
| inference/qwen3/results_gold/4b_tp2 |
| inference/qwen3/results_gold/4b_tp2_ascend |
| inference/qwen3_flaggems/results_gold/4b_tp2 |
| inference/robobrain2/results_gold/7b_tp2 |
| inference/robobrain2_flaggems/results_gold/7b_tp2 |

The one JSON gold file (`rl/qwen2_5/results_gold/0_5b.json`) was not
affected — JSON doesn't support comments so the header was never added
there.

Closes flagos-ai#1241's inference test failure.

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: zhaoyingli <86812880+zhaoyinglia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants