Configure FL backends before TP overlap initialization - #1263
Open
lihongyang1990 wants to merge 1 commit into
Open
Configure FL backends before TP overlap initialization#1263lihongyang1990 wants to merge 1 commit into
lihongyang1990 wants to merge 1 commit into
Conversation
lihongyang1990
requested review from
aoyulong,
heavyrain-lzy and
zhaoyinglia
as code owners
August 7, 2026 09:58
lihongyang1990
force-pushed
the
fix/te-backend-before-tp-overlap
branch
from
August 7, 2026 10:06
53bba4c to
35860fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
tp_comm_overlapis enabled,initialize_megatron()creates TransformerEngine UserBuffers before returning topretrain(). The existingTE_FL_*andMG_FL_PREFERenvironment variables were only set afterward, so calls made byinitialize_ub()could resolve and cache a backend beforete_fl_prefertook effect.Changes
pretrain()while keeping FlagGems enablement in its existing post-initialization position.With the configuration applied before UserBuffers are created, no post-initialization buffer rebuild is needed. The existing
distributed_backend: flagcxflow remains unchanged.