chore(deps): docker and jwt bump#1392
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates dependencies for the Docker SDK, migrating from older type references in github.com/docker/docker/api/types to their new locations in more specific subpackages like github.com/docker/docker/api/types/events, github.com/docker/docker/api/types/container, etc. The changes align with breaking changes in newer versions of the Docker SDK where types have been reorganized into more granular packages.
Key changes:
- Type migrations:
types.EventsOptions→events.ListOptions,types.StatsJSON→container.StatsResponse,types.ExecConfig→container.ExecOptions, etc. - Import path updates across multiple files to reflect new Docker SDK structure
- Variable and receiver name adjustments for consistency
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| logs/util/docker/event_stream.go | Updates event types to use events.ListOptions instead of types.EventsOptions and adds import for events package |
| logs/util/docker/event_pull.go | Similar event type migration, removes types import as it's no longer needed |
| logs/util/docker/docker.go | Renames variable from container to containerJson and updates GetContainerStats to return container.StatsResponse |
| inputs/keepalived/types/container/utils.go | Updates exec types to use container.ExecOptions and container.ExecStartOptions |
| inputs/docker/stats_helper.go | Updates all function signatures to use container.StatsResponse and container.MemoryStats |
| inputs/docker/docker.go | Updates type alias, receiver name, and various container-related types throughout |
| inputs/docker/client.go | Updates client interface and implementation to use new container types including container.StatsResponseReader |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -19,7 +19,7 @@ var ( | |||
| type Client interface { | |||
| Info(ctx context.Context) (system.Info, error) | |||
| ContainerList(ctx context.Context, options container.ListOptions) ([]types.Container, error) | |||
There was a problem hiding this comment.
The interface method signature for ContainerList returns []types.Container, but the implementation returns []container.Summary. This is a type mismatch that will cause compilation errors. The interface definition should be updated to match the implementation's return type.
* chore(deps): docker and jwt bump * chore(deps): reformat
No description provided.