Set CGO build flags and rust flags in builder environment#707
Merged
Conversation
bbhtt
changed the title
bbhtt
force-pushed
the
bbhtt/cgo-flags
branch
2 times, most recently
from
04bd4f2 to
0753033
Compare
swick
reviewed
Mar 9, 2026
bbhtt
force-pushed
the
bbhtt/cgo-flags
branch
3 times, most recently
from
c308b8e to
20aa67e
Compare
swick
reviewed
Mar 10, 2026
swick
approved these changes
Mar 10, 2026
When an override property is set in the manifest along with sdk default flags set but no explicit flags, builder_options_get_flags would return an empty string instead of NULL, causing a `--env=CFLAGS=` (and equivalent) being passed to the build. Return NULL in this case as well, which should not set the env var at all. Buildsystems might interpret this differently but the override properties as documented are not meant to affect the buildsystem's own internal handlings of the flags, rather only clear the accumulated flags of f-b.
Set CGO_CFLAGS, CGO_CXXFLAGS and CGO_LDFLAGS in the build environment. By default these inherit the values of cflags, cxxflags and ldflags respectively, unless overridden in the manifest. Fixes: #694
This inherits the SDK provided rustflags by default Fixes: #693
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #694
Fixes: #693