Backport some fixes to 1.4.x#718
Merged
bbhtt merged 7 commits intoflatpak-builder-1.4.xfrom Apr 1, 2026
Merged
Conversation
This aren't required since the test is checking for the presence of a mirrored icon link. Appstream tries to download screenshots if present and ignores download failures anyway silently. This may be contributing to the flakiness in [1]. Since the test already works offline, the screenshot links are redundant [1]: #714 (comment) (cherry picked from commit 0e9e1b3)
The YAML spec [1], [2] allows case-insensitive values for these and some more but we only want to support the subset that makes sense. [1]: https://yaml.org/type/bool.html [2]: https://yaml.org/type/null.html Fixes: #344 (cherry picked from commit b73531d)
(cherry picked from commit 9c4e3ea)
swick
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.