OAB: Update settings and add activity template - #52570
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #52570 +/- ##
==========================================
- Coverage 75.79% 75.79% -0.01%
==========================================
Files 4097 4097
Lines 247480 247498 +18
Branches 14068 14238 +170
==========================================
+ Hits 187573 187586 +13
- Misses 59731 59736 +5
Partials 176 176
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
There’s at least one confirmed runtime/type-safety issue (unsafe appConfig.mdm access and missing required IMdmConfig mock field) plus unmet spec-alignment/tests for the new behaviors.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR implements the frontend UI and activity-feed wiring for “Apple Business-only enrollment” (AB-only) mode, including Org settings controls, Integrations copy updates, and new activity templates/types.
Changes:
- Adds a new Advanced option toggle for “Allow only Apple Business enrollments” and updates the hardware attestation checkbox copy/help text.
- Updates the Apple Automatic Enrollment (ADE) card copy to conditionally remove BYOD language when AB-only mode is enabled.
- Adds two new activity types and renders them in the global activity feed + filter labels.
File summaries
| File | Description |
|---|---|
| frontend/pages/DashboardPage/cards/ActivityFeed/GlobalActivityItem/GlobalActivityItem.tsx | Adds templates/switch cases for two new AB-only enrollment activity types. |
| frontend/pages/admin/OrgSettingsPage/cards/Advanced/components/HostLifecycleSection/HostLifecycleSection.tsx | Updates Host lifecycle UI copy and adds the AB-only enrollment checkbox. |
| frontend/pages/admin/OrgSettingsPage/cards/Advanced/Advanced.tsx | Extends Advanced settings form state + PATCH payload to include the AB-only enrollment flag. |
| frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/AppleBusinessManagerSection/AppleBusinessManagerSection.tsx | Threads AB-only enrollment flag into the ADE card. |
| frontend/pages/admin/IntegrationsPage/cards/MdmSettings/components/AppleBusinessManagerSection/AppleAutomaticEnrollmentCard/AppleAutomaticEnrollmentCard.tsx | Conditionally adjusts ADE card copy when AB-only enrollment is enabled. |
| frontend/interfaces/config.ts | Adds the new MDM config field to the frontend config interface. |
| frontend/interfaces/activity.ts | Adds new ActivityType enum entries and filter-label mappings for AB-only enrollment activities. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 6
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. WalkthroughThe PR adds a required MDM configuration flag for Apple Business-only enrollment. Organization Advanced settings initialize and save the flag, and premium users can edit it alongside updated hardware attestation text. The Apple Business Manager ADE card displays different enrollment copy when the flag is enabled. The activity model and activity feed now support enabled and disabled Apple Business-only enrollment events. Merge Risk: ⚪ Minimal · up to This change adds Apple Business-only enrollment settings, related ADE messaging, and enrollment activity entries. The reviewed activity support is wired consistently and covered by focused tests, with no remaining merge-readiness risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The implementation covers the configuration field, organization settings checkbox, hardware-attestation rename, ADE card copy, activity types, filter labels, activity templates, and related activity-feed tests. The linked issue also requires updates to Advanced settings tests and ADE card tests, but the provided change summary shows only GlobalActivityItem tests.
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Related issue: Resolves #52064
Checklist for submitter
If some of the following don't apply, delete the relevant line.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.Testing
Frontend
Summary by CodeRabbit
New Features
Improvements