Skip to content

Add AMD Ryzen AI Developer Platform as a supported Linux platform - #52635

Open
allenhouchins wants to merge 2 commits into
mainfrom
claude/issue-52630-investigation-3386e6
Open

Add AMD Ryzen AI Developer Platform as a supported Linux platform#52635
allenhouchins wants to merge 2 commits into
mainfrom
claude/issue-52630-investigation-3386e6

Conversation

@allenhouchins

@allenhouchins allenhouchins commented Sep 6, 2026

Copy link
Copy Markdown
Member

Related issue: Resolves #52630

Summary

AMD Ryzen AI Developer Platform ships its own /etc/os-release with ID=amd-ryzen-ai-developer-platform (ID_LIKE=debian), so osquery reports that string as os_version.platform. Fleet stores the raw value on the host and filters detail queries by exact match against HostLinuxOSs, which did not include it. Every Linux-only detail query (network_interface_unix, disk_space_unix, users, os_unix_like, software_linux) was therefore never sent to these hosts, which explains all six gaps listed in the issue. Nothing is wrong on the device: running the underlying osquery tables directly on an affected host (osquery 5.23.1) returns data for mounts, interface_addresses/interface_details, users, and deb_packages.

This follows the same pattern as the Omarchy fix (#50069, commit 60ad78f):

  • Add amd-ryzen-ai-developer-platform to HostLinuxOSs and HostDebPackageOSs (the distro is deb-based).
  • Add it to HOST_LINUX_PLATFORMS in the frontend so the UI treats the host as Linux and shows Run script.
  • Regenerate understanding-host-vitals.md via go generate.
  • Tests mirroring the Omarchy ones: platform-to-linux mapping, LUKS unsupported, os_version ingest using the exact row a real host reports, OS inventory row, script filtering by platform, and the Run script dropdown.

Intentionally not added to IsLUKSSupported / DISK_ENCRYPTION_SUPPORTED_LINUX_PLATFORMS: the reference hardware runs plain btrfs with no LUKS layer, and Debian itself is not in those lists today. No OS-inventory aggregation is needed either; the name and 1.0.0 version parse cleanly to their own row.

Checklist for submitter

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.

Testing

  • Added/updated automated tests
  • QA'd all new/changed functionality manually

Ran locally (in containers, since the dev machine is the affected host and has no Go/yarn/MySQL):

  • go vet + gofmt on touched packages
  • go test ./server/fleet/ ./server/service/osquery_utils/ (targeted new/updated tests)
  • MYSQL_TEST=1 go test ./server/datastore/mysql/ -run TestScripts/GetHostScriptDetails
  • tsc --noEmit, eslint on changed frontend files, and the full HostActionsDropdown Jest suite (108 tests)

Manual QA still needed after deploy to dogfood: confirm disk space, private/public IP, MAC, users, and software populate on the enrolled AMD Ryzen AI Halo host.

Frontend

  • Attached a screenshot or screen recording of each user-visible change. For changes to existing UI, show the before and after.

No visual changes; only the platform allowlist gained an entry.

Summary by CodeRabbit

  • New Features

    • Added support for hosts running the AMD Ryzen AI Developer Platform on Debian-based Linux.
    • These hosts are now recognized as Linux systems with DEB package support.
    • Host inventory displays their platform and version details accurately.
    • Linux-specific actions, including running scripts, are available for supported hosts.
  • Bug Fixes

    • Prevented AMD Ryzen AI Developer Platform hosts from being incorrectly grouped with generic Debian systems.

Resolves #52630

AMD Ryzen AI Developer Platform ships its own /etc/os-release with
ID=amd-ryzen-ai-developer-platform (ID_LIKE=debian), so osquery reports
that string as the host platform. Since HostLinuxOSs and
HOST_LINUX_PLATFORMS gate nearly every Linux check, these hosts enrolled
but had no disk space, IP/MAC, users, or software inventory, were missed
by linux-scoped policies and labels, and lost Run script in the UI.

Add the platform to HostLinuxOSs, HostDebPackageOSs (deb-based), and
HOST_LINUX_PLATFORMS. Regenerate understanding-host-vitals.md. LUKS
support is intentionally not added; the reference hardware runs plain
btrfs with no encryption layer, matching Debian's current treatment.
Fleet now recognizes these hosts as Linux, allowing for population of host vitals, application of policies and labels, and execution of scripts.
@codecov

codecov Bot commented Sep 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.91%. Comparing base (626dd26) to head (a917619).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #52635   +/-   ##
=======================================
  Coverage   75.91%   75.91%           
=======================================
  Files        4102     4102           
  Lines      247984   247984           
  Branches    14100    14100           
=======================================
+ Hits       188266   188269    +3     
+ Misses      59542    59539    -3     
  Partials      176      176           
Flag Coverage Δ
backend 77.60% <ø> (+<0.01%) ⬆️
frontend 67.84% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@allenhouchins
allenhouchins marked this pull request as ready for review September 6, 2026 04:28
Copilot AI lite review requested due to automatic review settings September 6, 2026 04:28
@allenhouchins
allenhouchins requested a review from a team as a code owner September 6, 2026 04:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The change consistently updates backend/frontend platform allowlists and includes targeted regression tests covering the newly supported platform behaviors.

Warning

  • Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
Pull request overview

Adds support for the amd-ryzen-ai-developer-platform Linux os_version.platform value so Fleet treats these hosts as Linux for detail queries and script actions, resolving missing vitals/users/software inventory for that distro.

Changes:

  • Add amd-ryzen-ai-developer-platform to backend Linux platform allowlists and DEB package platforms.
  • Add the same platform to the frontend Linux platform allowlist so the UI enables Linux-only actions (e.g. Run script).
  • Add/extend Go and frontend tests to cover os_version ingest, platform mapping, script filtering, and the Run script dropdown.
File summaries
File Description
server/service/osquery_utils/queries_test.go Adds regression tests for ingesting os_version + OS inventory rows for the AMD Ryzen AI Developer Platform.
server/fleet/hosts.go Extends HostLinuxOSs and HostDebPackageOSs to recognize the new platform string.
server/fleet/hosts_test.go Verifies platform-to-linux mapping and confirms LUKS remains unsupported for this platform.
server/datastore/mysql/scripts_test.go Ensures Linux script filtering applies to the new platform (preventing Windows scripts from leaking into lists).
frontend/interfaces/platform.ts Adds the new platform to HOST_LINUX_PLATFORMS so frontend Linux checks include it.
frontend/pages/hosts/details/HostDetailsPage/HostActionsDropdown/HostActionsDropdown.tests.tsx Confirms “Run script” renders for this Debian-like Linux platform ID.
changes/52630-amd-ryzen-ai-developer-platform-linux-support Not reviewable here (content excluded by policy); appears to be the required changes entry for user-visible behavior.
docs/Contributing/product-groups/orchestration/understanding-host-vitals.md Not reviewable here (content excluded by policy); referenced as regenerated via go generate.
Review details

Files excluded by content exclusion policy (2)

  • changes/52630-amd-ryzen-ai-developer-platform-linux-support
  • docs/Contributing/product-groups/orchestration/understanding-host-vitals.md
  • Files reviewed: 6/8 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 76e0313c-6c0d-496a-873d-99eb1457674a

📥 Commits

Reviewing files that changed from the base of the PR and between 626dd26 and a917619.

⛔ Files ignored due to path filters (1)
  • docs/Contributing/product-groups/orchestration/understanding-host-vitals.md is excluded by !**/*.md
📒 Files selected for processing (7)
  • changes/52630-amd-ryzen-ai-developer-platform-linux-support
  • frontend/interfaces/platform.ts
  • frontend/pages/hosts/details/HostDetailsPage/HostActionsDropdown/HostActionsDropdown.tests.tsx
  • server/datastore/mysql/scripts_test.go
  • server/fleet/hosts.go
  • server/fleet/hosts_test.go
  • server/service/osquery_utils/queries_test.go

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


Walkthrough

Added AMD Ryzen AI Developer Platform to frontend and server Linux platform registries. Added DEB package support and Linux classification coverage. Added osquery ingestion tests for normalized platform data and separate inventory identity. Added tests for shell-script filtering and the Run script host action.

Merge Risk: ⚪ Minimal · up to a9176

AMD Ryzen AI Developer Platform hosts will now receive Linux host details, software inventory, and supported script actions without an identified current-head merge risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 6 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The changes address issue #52630 by adding the platform to Linux and Debian package allowlists. This enables the Linux detail queries and software inventory required for disk space, IP addresses, MAC …
Out of Scope Changes check ✅ Passed The changes are limited to platform allowlists, related tests, and the required user-visible changes file. They directly support the linked issue and stated pull request objectives.
Title check ✅ Passed The title clearly and concisely identifies the main change: adding AMD Ryzen AI Developer Platform as a supported Linux platform.
Description check ✅ Passed The description includes the related issue, change summary, testing details, checklist status, frontend impact, and manual QA notes. It is specific to the pull request and sufficiently addresses the r…
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 6 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/issue-52630-investigation-3386e6

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@allenhouchins

Copy link
Copy Markdown
Member Author

Confirmed fixed:
Screenshot 2026-09-05 at 11 49 15 PM

Screenshot 2026-09-05 at 11 49 28 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AMD Ryzen AI Developer Platform 1.0.0 hosts: missing vitals, user accounts, and software inventory

2 participants