Exclude staged Webex upgrade bundles from macOS patch policy - #52636
Draft
allenhouchins wants to merge 2 commits into
Draft
Exclude staged Webex upgrade bundles from macOS patch policy#52636allenhouchins wants to merge 2 commits into
allenhouchins wants to merge 2 commits into
Conversation
Webex's auto-updater caches fully formed Webex.app bundles under ~/Library/Application Support/Cisco Spark/Webexteams_upgrades_* and can re-stage them between FMA installs, so the install script's cleanup is not enough. Ignore those paths in the patched query so stale cached bundles no longer fail the policy on hosts that are already current.
fleet-release
previously approved these changes
Sep 6, 2026
allenhouchins
temporarily deployed
to
Docker Hub
September 6, 2026 03:08 — with
GitHub Actions
Inactive
fleet-release
approved these changes
Sep 6, 2026
fleet-release
approved these changes
Sep 6, 2026
allenhouchins
temporarily deployed
to
Docker Hub
September 6, 2026 03:28 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #47440
Summary
Webex's own auto-updater stages fully formed
Webex.appbundles under~/Library/Application Support/Cisco Spark/Webexteams_upgrades_*. Those bundles share the real app's bundle identifier (Cisco-Systems.Spark) at an older version, so osquery'sappstable reports them and the FMA patch policy fails on hosts that are actually on the current version.The install script already deletes those directories after a successful install, but Webex re-stages them between FMA installs/updates, so the cleanup alone isn't enough (the issue was reopened for
customer-panoramixon 2026-09-04).This PR excludes that path in the generated patched query, following the existing
docker-desktopprecedent for.backbundles:Changes
ee/maintained-apps/ingesters/homebrew/ingester.go: add awebexpatched-query override alongside thedocker-desktopone.ee/maintained-apps/ingesters/homebrew/ingester_test.go: add awebexcase asserting the exists/patched queries.ee/maintained-apps/outputs/webex/darwin.json: regenerated withgo run ./cmd/maintained-apps -slug webex/darwin. Only thepatchedquery changed; version, installer URL and script refs are unchanged, so existing installs pick up the new policy on the next FMA sync.The
remove_stale_upgrade_bundlescleanup in the install script is kept as-is.Note:
_is a single-character wildcard inLIKE, so the underscores are escaped (ESCAPE '\', the same form Fleet already uses in its host-detail user query). The pattern starts at/Library/Application Support/rather than/Users/so home directories outside/Usersare covered.Checklist for submitter
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements), JS inline code is prevented especially for url redirects, and untrusted data interpolated into shell scripts/commands is validated against shell metacharacters.Testing