Skip to content

sd_fft: Add more documentation#2713

Merged
fredrik-johansson merged 1 commit into
flintlib:mainfrom
user202729:sd-fft-more-documentation
Jun 9, 2026
Merged

sd_fft: Add more documentation#2713
fredrik-johansson merged 1 commit into
flintlib:mainfrom
user202729:sd-fft-more-documentation

Conversation

@user202729

@user202729 user202729 commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

Mostly trying to understand the algorithm myself.

The notation

$A$ independent contiguous $B$-layer transforms with length $(C, C/2, \dots, C/2^{B-1})$ and mask $(D‥E)$

is probably not standard, but I think it's understandable enough. I didn't formally define it either, but (I hope…) the formal definition is clear from the examples.

(It seems to me that mathematicians prefer formal definitions, implementors prefer "definitions" by examples. We're both. Upside of formal definition is it can be understood eventually given enough effort, downside is if the examples can be understood then it would take more effort to read the formal definitions.)

While writing the documentation, I notice that the internal variants do not make sense with S != 1, so I simplify it by deleting that argument. Should translate to a tiny performance improvement.

The numbering of the layers might have been backward (it's internally consistent, problem is it may be bad notation).

@fredrik-johansson fredrik-johansson merged commit db429f0 into flintlib:main Jun 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants