Skip to content

FLOE-471: Transfer pouchPersisted and eventInTimeAware grades from Learning Dashboard prototype to new MyL3 repo - #1

Closed
waharnum wants to merge 209 commits into
fluid-project:masterfrom
waharnum:FLOE-471
Closed

FLOE-471: Transfer pouchPersisted and eventInTimeAware grades from Learning Dashboard prototype to new MyL3 repo#1
waharnum wants to merge 209 commits into
fluid-project:masterfrom
waharnum:FLOE-471

Conversation

@waharnum

Copy link
Copy Markdown
Member

Per this Jira

These grades have important base functionality (persistence and time-awareness) for the MyL3 project.

Since the PR introduces a lot of files, these are the ones that should be reviewed:

  • examples/*
  • src/js/*
  • tests/html
  • tests/js

@waharnum

waharnum commented Sep 9, 2016

Copy link
Copy Markdown
Member Author

I think this is ready for another look, @jobara / @amb26.

Comment thread examples/pouchPersisted/index.html Outdated
</ul>
</div>
<script>
fluid.defaults("floe.dashboard.pouchPersistedInlineEdit", {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lengthy script block should be broken out into a .js file

@waharnum

Copy link
Copy Markdown
Member Author

@amb26 I'm having some trouble understanding the comments about reusing the logic from the CouchDB dataSource grade - that appears to be a mixin grade for the node-based kettle.dataSource.URL grade, which I don't think I can make use of here since this is running in-browser only. Can you clarify your meaning?

@the-t-in-rtf

Copy link
Copy Markdown

@waharnum, as we discussed in our meeting, there is an approach to browserifying the required deps and just using the existing grade, but as you are not just talking about tests, it sounds like you (also) need a jQuery-backed dataSource. Not sure I can fit anything in this week, let's discuss in today's meeting.

@waharnum

waharnum commented May 8, 2018

Copy link
Copy Markdown
Member Author

Closing this PR since @simonbates is starting a new round of work on this project.

@waharnum waharnum closed this May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants