Export EventNewInfo in public API - #572
Closed
eschmidbauer wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
needs more work. will open another PR shortly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Export
EventNewInfofromsip_uapublic APISummary
EventNewInfovia the publicsip_ua.dartexport list so downstream apps can subscribe to SIP INFO events withoutimplementation_imports.Why
EventNewInfo, but the type isn’t publicly exported.lib/srcto listen for INFO, which triggersimplementation_importswarnings and is fragile.Changes
EventNewInfoinlib/sip_ua.dart.Testing
Notes