Expose registrator accessor for runtime REGISTER customization - #575
Closed
mechtech-mind wants to merge 2 commits into
Closed
Expose registrator accessor for runtime REGISTER customization#575mechtech-mind wants to merge 2 commits into
mechtech-mind wants to merge 2 commits into
Conversation
Contributor
Author
|
Hi @cloudwebrtc 👋 Just a gentle follow-up on this PR when you have time. All checks are passing, and I’m happy to make any adjustments if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR exposes a safe accessor for the internal
Registratorinstance so thatapplications can modify REGISTER / UNREGISTER extra Contact parameters at runtime
without forking the library.
Why this is needed
Some applications (e.g. RFC8599 / push / call correlation use cases) need to add
dynamic Contact URI parameters at the moment of REGISTER, such as a runtime
UUID or call identifier.
Previously this was not possible without forking, because:
UA._registratorwas privateSIPUAHelperhad no way to reach the active registratorChanges
registratorInstancegetter inUAregistratorgetter inSIPUAHelperUsage example
Notes
internals, as the underlying capability already existed but was not exposed via
the public plugin API.
Thanks!
Also feedback on additional test coverage or documentation improvements is welcome.