chore: update example project to Flutter 3.22, fix web interop, bump dependencies - #586
Open
giovanniPolatoO wants to merge 1 commit into
Open
chore: update example project to Flutter 3.22, fix web interop, bump dependencies#586giovanniPolatoO wants to merge 1 commit into
giovanniPolatoO wants to merge 1 commit into
Conversation
Bumps Flutter SDK to 3.22.0 and Dart SDK to 3.4.0. This includes: - Updating Android Gradle Plugin, Kotlin, and Gradle wrapper versions. - Migrating iOS project files for CocoaPods integration, `AppDelegate` changes, and `Info.plist` updates for scene manifest. - Adjusting web interop for WebSocket protocol handling. - Updating various package dependencies in the example project.
|
This change overlaps with PR #568, which already applies the same fix. |
Author
|
Hi @himanshujjp, thanks for pointing that out! Do you know if/when #568 is expected to be merged? If it already covers the WebSocket/js_interop fix for web, I'm happy to rebase this PR on top of it and keep only the additional changes here (Android Gradle/AGP/Kotlin updates and dependency bumps), to avoid duplicating work. Let me know how you'd like to proceed — happy to close this one and open a follow-up once #568 lands, or keep it open and adjust the diff, whichever is easier to manage on your end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes the example project and fixes a compilation error on Flutter Web
caused by breaking changes in dart:js_interop.
Fixes
compatibility (WebSocket(_url, 'sip') → WebSocket(_url, ['sip'.toJS].toJS))
Resolves compilation error: "The argument type 'String' can't be assigned
to the parameter type 'JSAny'"
Android
SDK & Environment
Dependencies (example/pubspec.yaml)
Notes
flutter-webrtc/flutter-webrtc. No action possible on our side yet.