Fix enqueue, resume and retry callback for Android.#284
Open
addie9000 wants to merge 3 commits intofluttercommunity:masterfrom
Open
Fix enqueue, resume and retry callback for Android.#284addie9000 wants to merge 3 commits intofluttercommunity:masterfrom
addie9000 wants to merge 3 commits intofluttercommunity:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Android, it seems that the callback registered by FlutterDownloader.registerCallback method does not work with enqueue, resume and retry.
Because sendUpdateProgress does not work due to there is no handler for "updateProgress".
I look back the code history and find that before commit 03544c7 it was handle at FlutterDownloader.registerCallback.
So I put that code to the same place.
This could fixes #191