Feat: support tracking binaryData in CM and stringData in Secret#1781
Open
MengjiaLiang wants to merge 1 commit into
Open
Feat: support tracking binaryData in CM and stringData in Secret#1781MengjiaLiang wants to merge 1 commit into
MengjiaLiang wants to merge 1 commit into
Conversation
Signed-off-by: MengjiaLiang <mengjia.liang@uipath.com>
|
@aryan9600 @stefanprodan |
aryan9600
reviewed
May 24, 2026
aryan9600
left a comment
aryan9600
left a comment
Member
There was a problem hiding this comment.
this needs to be feature gated via a cli flag to avoid unwanted canary runs when users upgrade to a version with this patch.
| // getFullDataFromSecret fetches both data and stringData in the secret | ||
| func (ct *ConfigTracker) getFullDataFromSecret(secret corev1.Secret) map[string]string { | ||
| fullData := make(map[string]string) | ||
| maps.Copy(fullData, secret.StringData) |
Member
There was a problem hiding this comment.
stringData in a secret is a write only field. the data written through this field is returned in data on reads, which is already used to calculate the checksum
|
Thanks @aryan9600 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Flagger does not support creating/tracking/promoting the binaryData in a configmap and the stringData in a secret.
This change tries to support these scenarios.