adding BackendTimeout for Gateway API router#1920
Merged
aryan9600 merged 2 commits intoMay 24, 2026
Merged
Conversation
Signed-off-by: Danny Kulchinsky <dkulchinsky@fastly.com>
aryan9600
reviewed
May 23, 2026
aryan9600
left a comment
Member
There was a problem hiding this comment.
left a small nit, but lgtm otherwise - thanks! 🙇
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1920 +/- ##
==========================================
- Coverage 30.18% 30.00% -0.19%
==========================================
Files 288 288
Lines 18533 18455 -78
==========================================
- Hits 5594 5537 -57
+ Misses 12204 12189 -15
+ Partials 735 729 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com> Signed-off-by: Danny Kulchinsky <61992380+dkulchinsky@users.noreply.github.com>
aryan9600
approved these changes
May 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adding
service.backendTimeoutfor Gateway API router that maps toHTTPRouteTimeouts.BackendRequest, this complements the existingservice.timeoutsetting that maps toHTTPRouteTimeouts.Request