Skip to content

adding BackendTimeout for Gateway API router#1920

Merged
aryan9600 merged 2 commits into
fluxcd:mainfrom
dkulchinsky:dannyk/gatewayapi_backendRequest_timeout
May 24, 2026
Merged

adding BackendTimeout for Gateway API router#1920
aryan9600 merged 2 commits into
fluxcd:mainfrom
dkulchinsky:dannyk/gatewayapi_backendRequest_timeout

Conversation

@dkulchinsky

@dkulchinsky dkulchinsky commented May 20, 2026

Copy link
Copy Markdown
Contributor

adding service.backendTimeout for Gateway API router that maps to HTTPRouteTimeouts.BackendRequest, this complements the existing service.timeout setting that maps to HTTPRouteTimeouts.Request

Signed-off-by: Danny Kulchinsky <dkulchinsky@fastly.com>

@aryan9600 aryan9600 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a small nit, but lgtm otherwise - thanks! 🙇

Comment thread docs/gitbook/tutorials/gatewayapi-progressive-delivery.md Outdated
@codecov-commenter

codecov-commenter commented May 23, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 76.47059% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.00%. Comparing base (cd964bb) to head (61582f7).
⚠️ Report is 16 commits behind head on main.

Files with missing lines Patch % Lines
pkg/router/gateway_api.go 76.47% 4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1920      +/-   ##
==========================================
- Coverage   30.18%   30.00%   -0.19%     
==========================================
  Files         288      288              
  Lines       18533    18455      -78     
==========================================
- Hits         5594     5537      -57     
+ Misses      12204    12189      -15     
+ Partials      735      729       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Sanskar Jaiswal <jaiswalsanskar078@gmail.com>
Signed-off-by: Danny Kulchinsky <61992380+dkulchinsky@users.noreply.github.com>
@aryan9600 aryan9600 merged commit 83bab68 into fluxcd:main May 24, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants