Skip to content

refactor(framework): Skip installation of dependencies in flwr new message#7477

Merged
panh99 merged 3 commits into
mainfrom
update-flwr-new-instructions
Jun 23, 2026
Merged

refactor(framework): Skip installation of dependencies in flwr new message#7477
panh99 merged 3 commits into
mainfrom
update-flwr-new-instructions

Conversation

@jafermarq

Copy link
Copy Markdown
Member

Before:

 flwr new @flwrlabs/quickstart-jax

🔗 Requesting download link for @flwrlabs/quickstart-jax...
🔽 Downloading app...
📦 Unpacking app into /Users/javier/quickstart-jax...
🎊 Flower App creation successful.

To run your Flower App, first install its dependencies:

        cd quickstart-jax && pip install -e .

then, run the app:

        flwr run .

💡 Check the README in your app directory to learn how to
customize it and how to run it using the Deployment Runtime.

after:

flwr new @flwrlabs/quickstart-jax

🔗 Requesting download link for @flwrlabs/quickstart-jax...
🔽 Downloading app...
📦 Unpacking app into /Users/javier/quickstart-jax...
🎊 Flower App creation successful.

Run the app as follows:

        flwr run quickstart-jax --stream

💡 Check the README in your app directory to learn how to
customize it and how to run it using the Deployment Runtime.

Copilot AI review requested due to automatic review settings June 23, 2026 16:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the flwr new CLI success message to reflect the newer workflow where users can immediately run a freshly created app without being prompted to install dependencies.

Changes:

  • Simplifies the post-creation prompt by removing the pip install -e . guidance.
  • Replaces the “cd + run” instructions with a single flwr run <app_dir> --stream command.
  • Keeps the README guidance intact while adjusting the surrounding prompt text.

Critical issues

  • None.

Simplicity/readability suggestions

  • Minor: remove the trailing space in the printed flwr run ... --stream command (PR comment added).

Consistency concerns

  • None.

Whether the PR should be split

  • No.

Overall verdict

  • Looks good; only a minor prompt-formatting nit.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread framework/py/flwr/cli/new/new.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 227126f560

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread framework/py/flwr/cli/new/new.py Outdated
@github-actions github-actions Bot added the Maintainer Used to determine what PRs (mainly) come from Flower maintainers. label Jun 23, 2026

@panh99 panh99 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@panh99 panh99 enabled auto-merge (squash) June 23, 2026 21:10
@panh99 panh99 disabled auto-merge June 23, 2026 21:10
@panh99 panh99 enabled auto-merge (squash) June 23, 2026 21:10
@panh99 panh99 merged commit 7079b8a into main Jun 23, 2026
61 checks passed
@panh99 panh99 deleted the update-flwr-new-instructions branch June 23, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maintainer Used to determine what PRs (mainly) come from Flower maintainers. runtime-dependencies-install

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants