Update generated Dockerfile and entrypoint.sh to decrease deploy time#50
Merged
Merged
Conversation
1. Upgrade to Laravel Zero 11, for PHP8.4.1 2. Update Readme to mention upgrading the framework as a solution to failing builds 3. Update Dockerfile and entrypoint.sh generated to move last chown into build time and not run time, this significantly slows down deploys 4. Update Dockerfile to use build script if vite.config.ts is detected
Roadmaster
approved these changes
Jul 18, 2025
Roadmaster
left a comment
There was a problem hiding this comment.
LGTM a couple of minor suggestions.
| RUN rsync -ar /var/www/html/public-npm/ /var/www/html/public/ \ | ||
| && rm -rf /var/www/html/public-npm \ | ||
| && chown -R www-data:www-data /var/www/html/public | ||
| && chown -R www-data:www-data /var/www/html/public \ |
There was a problem hiding this comment.
/var/www/html contains /var/www/html/public; so you can remove line 131 altogether, line 132 takes care of everything.
| php dockerfile-laravel app:build | ||
| ``` | ||
|
|
||
| ### Getting Pass Hurdles |
…rally be a cause of permission issue as once theyve been created www-data wouldnt need write permissions to them anymore--since theyre cache generated files right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So! Due to rootfs throttling, will need to move the chown command in entrypoint.sh away from runtime and into build time. Otherwise! the deploy time's really slow:
Main Changes related to title:
Other changes made:
To make this change available: