Skip to content

MSEARCH-1245: Provide http client configuration for MinioS3Client/AwsS3Client - #77

Merged
viacheslavkol merged 1 commit into
masterfrom
MSEARCH-1245
Jun 17, 2026
Merged

MSEARCH-1245: Provide http client configuration for MinioS3Client/AwsS3Client#77
viacheslavkol merged 1 commit into
masterfrom
MSEARCH-1245

Conversation

@viacheslavkol

Copy link
Copy Markdown
Contributor

Purpose

S3 reindexing performance is much worse comparing to kafka reindexing. The assumption is that http client for s3 client is the bottleneck. This PR aims to add http client and connection pool configuration

Approach

Provide http client configuration for MinioS3Client/AwsS3Client

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

@viacheslavkol viacheslavkol self-assigned this Jun 17, 2026
@sonarqubecloud

Copy link
Copy Markdown

@viacheslavkol
viacheslavkol marked this pull request as ready for review June 17, 2026 13:26
@viacheslavkol
viacheslavkol requested review from a team, SvitlanaKovalova1 and psmagin and removed request for a team June 17, 2026 13:27
@viacheslavkol
viacheslavkol merged commit 98b9849 into master Jun 17, 2026
16 checks passed
@viacheslavkol
viacheslavkol deleted the MSEARCH-1245 branch June 17, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants