Skip to content

CIRCSTORE-652: Undeploy verticle before stopping Kafka #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julianladisch merged 2 commits into from
Jun 23, 2026
Merged

CIRCSTORE-652: Undeploy verticle before stopping Kafka #573

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7141d2
CIRCSTORE-652: Undeploy verticle before stopping Kafka in StorageTest…
julianladisch May 12, 2026
011ba16
Merge branch 'master' into CIRCSTORE-652-undeployVerticle
roman-barannyk May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/test/java/org/folio/rest/api/StorageTestSuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ public class StorageTestSuite {
public static final String TENANT_ID = "test_tenant";

private static Vertx vertx;
private static String restVerticleId;
public static final int PROXY_PORT = NetworkUtils.nextFreePort();
public static final int OKAPI_MOCK_PORT = NetworkUtils.nextFreePort();
private static boolean initialised = false;
Expand Down Expand Up @@ -196,6 +197,12 @@ public static void after()
log.warn("after:: removeTenant failed (ignored): {}", e.getMessage());
}

try {
stopVerticle();
} catch (Throwable e) {
log.warn("after:: stopVerticle failed (ignored): {}", e.getMessage());
}

try {
kafkaContainer.stop();
} catch (Throwable e) {
Expand Down Expand Up @@ -309,7 +316,12 @@ private static void startVerticle(DeploymentOptions options)
.onSuccess(deploymentComplete::complete)
.onFailure(deploymentComplete::completeExceptionally);

deploymentComplete.get(30, TimeUnit.SECONDS);
restVerticleId = deploymentComplete.get(30, TimeUnit.SECONDS);
}

private static void stopVerticle() throws InterruptedException, ExecutionException, TimeoutException {
vertx.undeploy(restVerticleId)
.toCompletionStage().toCompletableFuture().get(5, TimeUnit.SECONDS);
}

static protected void prepareTenant(String tenantId, boolean loadSample) {
Expand Down
Loading