CIRC-2644: Fix matching ECS TLR request to item being checked out in non data tenant - #1686
Open
mukhiddin-yusuf wants to merge 3 commits into
Open
CIRC-2644: Fix matching ECS TLR request to item being checked out in non data tenant #1686mukhiddin-yusuf wants to merge 3 commits into
mukhiddin-yusuf wants to merge 3 commits into
Conversation
…t in non-data tenant (DCB item)
mukhiddin-yusuf
requested review from
OleksandrVidinieiev,
alexanderkurash and
roman-barannyk
July 27, 2026 12:44
roman-barannyk
approved these changes
Jul 28, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
For ECS TLR, checking-out item from the same title by barcode fails in a non-data tenant when an additional ILR Hold request for the same item but different requester exist. Mismatch between
instanceIds for the DCB item and the one stored in request causes a false "requested by another patron" validation error.Approach
Skip the comparison of DCB and real Item's instance IDs for DCB items (or in non-data tenants)
TODOS and Open Questions
Learning
CIRC-2644