Skip to content

[MODEXPW-637] Fix spring batch configuration to use jdbc repository - #741

Merged
viacheslavkol merged 2 commits into
masterfrom
MODEXPW-637
Jun 11, 2026
Merged

[MODEXPW-637] Fix spring batch configuration to use jdbc repository#741
viacheslavkol merged 2 commits into
masterfrom
MODEXPW-637

Conversation

@viacheslavkol

@viacheslavkol viacheslavkol commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Purpose

Fix multiple eHoldings jobs failing when run simultaneously

Approach

Fix spring batch configuration to use jdbc repository
Rename old BATCH_JOB_SEQ to the new Spring-Batch-6 version - BATCH_JOB_INSTANCE_SEQ

Learning

Spring boot upgrade to version 4 brought the Spring Batch 6. For jdbc repository to be used by spring batch additional configuration is now required. Sequence name is also changed
Migration to Spring Boot 4.0
Spring-Boot-4.0-Migration-Guide
Spring-Batch-6.0-Migration-Guide

Manual testing

Tested on dev environment. Jobs 1-3 were ran before the fix, 4-6 were ran after the fix was deployed
image

Pre-Merge Checklist:

Before merging this PR, please go through the following list and take appropriate actions.

  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • Check logging
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • Were any API paths or methods changed, added or removed?
    • Were there any schema changes?
    • Did any of the interface versions change?
    • Were permissions changed, added, or removed?
    • Are there new interface dependencies?
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

@viacheslavkol viacheslavkol self-assigned this Jun 9, 2026
@sonarqubecloud

sonarqubecloud Bot commented Jun 9, 2026

Copy link
Copy Markdown

@viacheslavkol
viacheslavkol marked this pull request as ready for review June 10, 2026 13:48
@viacheslavkol
viacheslavkol requested review from a team, SvitlanaKovalova1, obozhko-folio and psmagin and removed request for a team June 10, 2026 13:48
@viacheslavkol
viacheslavkol merged commit 249b2bc into master Jun 11, 2026
16 checks passed
@viacheslavkol
viacheslavkol deleted the MODEXPW-637 branch June 11, 2026 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants