Fix handling of included feature files - #150
Merged
Merged
Conversation
Member
Author
|
FWIW it's about this fragment in the .glyphs file: featurePrefixes = (
{
code = "include(ExternalFeatureFile.fea);
";
name = include;
},
{
automatic = 1;
code = "languagesystem DFLT dflt;
";
name = Languagesystems;
}
);The included file comes first bit (the file contains a |
Member
Author
|
@khaledhosny, do you happen to know any Glyphs-based projects that are built with fontmake and use an external .fea file? |
Contributor
|
Inter seems to use external feature files: https://github.com/rsms/inter/tree/master/src |
…at it in the external .fea file
Member
Author
|
I checked with the Inter sources, and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #149.
However: the test font (
ExternalFeatureFile.glyphs) still does not work with Fontra or fontmake, because it causes the expanded features to have alanguagesystemstatement that is not at the top of the file.This file was modeled after a real project, and I'm not sure if this is a construct that Glyphs handles fine on export and only fontc and fontmake complain about, or whether the test file ended up being atypical. Cc @faebiou, @RafalBuchner.