Skip to content

feat: add tsImportExtension config for TypeScript import paths #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicolaturcato wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −3
Open

feat: add tsImportExtension config for TypeScript import paths #101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3b7659
feat: add tsImportExtension config option for TypeScript import paths
nicolaturcato Apr 10, 2026
11b413c
fix: align schema with auto-generated output from TestSchema
nicolaturcato Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ type Config struct {
Targets map[string]*Target `json:"targets" yaml:"targets"`
// Map of go module names to TypeScript mapping settings
Mappings TypeScriptMappings `json:"mappings" yaml:"mappings"`
// Optional file extension to append to relative TypeScript import paths (e.g. ".js")
TSImportExtension string `json:"tsImportExtension" yaml:"tsImportExtension"`
}

func LoadConfigFile(file string) (conf *Config, err error) {
Expand Down
3 changes: 3 additions & 0 deletions gotsrpc.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@
},
"mappings": {
"$ref": "#/$defs/TypeScriptMappings"
},
"tsImportExtension": {
"type": "string"
}
},
"additionalProperties": false,
Expand Down
6 changes: 3 additions & 3 deletions internal/build/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,13 +278,13 @@ func deriveCommonJSMapping(conf *config.Config) {
}
}

func relativeFilePath(a, b string) (r string, e error) {
func relativeFilePath(a, b, ext string) (r string, e error) {
r, e = filepath.Rel(path.Dir(a), b)
if e != nil {
return
}

r = strings.TrimSuffix(r, ".ts")
r = strings.TrimSuffix(r, ".ts") + ext

return
}
Expand All @@ -304,7 +304,7 @@ func commonJSImports(conf *config.Config, c *codegen.Code, tsFilename string, co
continue
}

relativePath, relativeErr := relativeFilePath(tsFilename, importMapping.Out)
relativePath, relativeErr := relativeFilePath(tsFilename, importMapping.Out, conf.TSImportExtension)
if relativeErr != nil {
fmt.Println("can not derive a relative path between", tsFilename, "and", importMapping.Out, relativeErr)
os.Exit(1)
Expand Down
Loading