@W-19964705: [MSDK Android] Push Notification Registration Failure For User Accounts With Community URL

[JohnsonEricAtSalesforce]

🎸 Ready For Review 🥁

This corrects the network_id field when registering for SFDC push notifications, which was incorrectly set to the community URL instead of the community id.

[wmathurin]

Maybe we could add tests for this method by using the approach used in AuthenticationUtilities / AuthenticationUtilitiesTest
where we have a bunch of parameters that take lambda functions but default to calling existing helper methods?

[JohnsonEricAtSalesforce]

Maybe we could add tests for this method by using the approach used in AuthenticationUtilities / AuthenticationUtilitiesTest where we have a bunch of parameters that take lambda functions but default to calling existing helper methods?

As it turns out, I wrote a set of tests around PushService earlier in the yet. We could add a test for this value like this commit 👉🏻 d914477

[mani516]

@wmathurin @JohnsonEricAtSalesforce

Hi there!

Thanks for identifying and fixing this one. However it seems this fix is not yet available in the latest release i.e., 13.1.1

When can we expect this fix to be released? This is blocking our sdk upgrade from 11.1.0, to support 16kb page sizes, for which the extended deadline is 31 May 2026.

Although, it looks like the above change was related to a code change which was done in 13.1.0 - 5e40cff

But we were facing issue while migrating to 13.0.2 also (from 11.1.0).

Usecase 1

1. Install app with salesforce sdk 11.1.0
2. Launch app
3. setDelayRegistrationUntilContactKeyIsSet is set to true
4. SFMCSdk initStatus returns Success (1)
5. Login the User
6. Update the app with Salesforce Sdk 13.0.2
7. Launch app
8. SFMCSdk initStatus returns Failure (-1)

Usecase 2

1. Install app with salesforce sdk 11.1.0
2. Launch app
3. setDelayRegistrationUntilContactKeyIsSet is set to true
4. SFMCSdk initStatus returns Success (1)
5. Dont login the user
6. Update the app with Salesforce Sdk 13.0.2
7. Launch app
8. SFMCSdk initStatus still returns Success (1)
9. Login the user
10. Relaunch the app
11. SFMCSdk initStatus returns Failure (-1)