Fix AndroidManifest issues and warnings in test libraries. - #2810
Merged
Conversation
brandonpage
commented
Dec 3, 2025
Comment on lines
-20
to
-23
| <!-- Disabling AILTN in tests --> | ||
| <service android:name="com.salesforce.androidsdk.analytics.AnalyticsPublisherService" | ||
| android:enabled="false" | ||
| android:exported="false" /> |
brandonpage
commented
Dec 3, 2025
Comment on lines
+10
to
+19
| <!-- Service required for authentication --> | ||
| <service android:exported="true" | ||
| android:name="com.salesforce.androidsdk.auth.AuthenticatorService" | ||
| tools:ignore="ExportedService"> | ||
| <intent-filter> | ||
| <action android:name="android.accounts.AccountAuthenticator" /> | ||
| </intent-filter> | ||
| <meta-data android:name="android.accounts.AccountAuthenticator" | ||
| android:resource="@xml/authenticator" /> | ||
| </service> |
Contributor
Author
There was a problem hiding this comment.
Not declaring this causes a "Fatal exception" when running tests:
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #2810 +/- ##
=============================================
- Coverage 61.77% 43.68% -18.10%
+ Complexity 2767 2061 -706
=============================================
Files 214 214
Lines 16931 16931
Branches 2453 2453
=============================================
- Hits 10459 7396 -3063
- Misses 5306 8629 +3323
+ Partials 1166 906 -260
🚀 New features to boost your workflow:
|
wmathurin
approved these changes
Dec 3, 2025
Generated by 🚫 Danger |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.