W-23195012: Android DP per-user feature flag for DPoP sessions - #2962
Merged
Conversation
- Add FEATURE_DPOP = "DP" constant to Features.java - Register/unregister FEATURE_DPOP per-user in LoginActivity.onAuthFlowSuccess() based on tokenType - Extend validateUserAgent() in AuthFlowTesterPageObject with isDpop parameter; assert DP flag present/absent - Thread isDpop through loginAndValidate() and assertRevokeAndRefreshWorks() in AuthFlowTest - Update all DPoP test call sites in DPoPLoginTests, RefreshTokenMigrationTests with isDpop=true
- Remove redundant isDpop parameter from loginAndValidate() — derive val isDpop = useDPoP internally instead - Remove isDpop from RefreshTokenMigrationTests loginAndValidate override - Remove isDpop = true from all DPoPLoginTests loginAndValidate call sites - Add test_givenDPoPSession_whenRegisterDPFeature_thenDPFlagAppearsInUserAgentForUser to SalesforceSDKManagerTests covering per-user isolation of DP flag
Generated by 🚫 Danger |
…e matches iOS behaviour
…s only issued at token endpoint Salesforce confirmed DPoP-Nonce is only returned by the token endpoint. The inline harvest+retry in callIdentityService() could never fire. Identity 401s already recover via OAuthRefreshInterceptor, which re-enters the token endpoint where nonce handling lives. Aligns Android with iOS behaviour.
brandonpage
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FEATURE_DPOP = "DP"constant toFeatures.javaDPper-user flag at auth completion inLoginActivity.onAuthFlowSuccess()based ontokenType == "DPoP"; persists via W-23159744 infrastructurevalidateUserAgent()inAuthFlowTesterPageObjectwithisDpopassertion; threaded throughAuthFlowTestandDPoPLoginTestsisDpopderived fromuseDPoPMultiUserLoginTests; restoresuseHybridAuthToken = falsewith TODO W-20524841 inRefreshTokenMigrationTestsOAuth2.callIdentityService()— Salesforce only issuesDPoP-Nonceat the token endpoint, so the inline retry could never fire. Identity 401s already recover viaOAuthRefreshInterceptor→ token endpoint. Aligns Android with iOS behaviour.Test plan
DPoPLoginTests— all pass withDPflag assertionsRegularLoginTests) —DPflag absentDPflag survives app restartDPcleared on migration to non-DPoP session