W-23192897: surface DPoP runtime state in developer info screen - #2963
Merged
Conversation
…in dev info screen Add OAuth Token Type row (always) and DPoP Nonce + DPoP Key Thumbprint rows (DPoP sessions only) to the Current User section of DevInfoActivity. Add jwkThumbprint() to DPoPProofBuilder for RFC 7638 JWK SHA-256 thumbprint. Add docs/dev-info-screen.md reference doc for the developer info screen.
…pUrl.get().host()
…tials Add DPoP Key Thumbprint row to UserCredentialsView (DPoP section) and expose it via DpopInfo in the page object. validateOAuthValues() now asserts the thumbprint is a valid 43-char base64url string, matching the RFC 7638 JWK thumbprint that DevSupportInfo already computes.
Contributor
|
We should remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jwkThumbprint(ECPublicKey)toDPoPProofBuilder— RFC 7638 JWK SHA-256 thumbprint of the EC P-256 public keyDevSupportInfo.parseUserInfoSection()with three new rows in the Current User section:"Bearer"or"DPoP")"None"jktclaim, or"Unavailable"if key cannot be loadedcreateFromLegacyDevInfos()to include the three new keys for backward-compat pathdocs/dev-info-screen.md— reference doc for the developer info screen architectureTest plan
OAuth Token Type = "Bearer", no DPoP Nonce or Thumbprint rows"None"when cache empty; thumbprint shows"Unavailable"if key load failsjwkThumbprint()produces a valid 43-char base64url stringDevSupportInfoTesttests pass (verified locally on emulator)