feat(W-23201584): surface App Attestation state in developer info screen - #2978
Open
wmathurin wants to merge 4 commits into
Open
feat(W-23201584): surface App Attestation state in developer info screen#2978wmathurin wants to merge 4 commits into
wmathurin wants to merge 4 commits into
Conversation
- Features.java: add FEATURE_APP_ATTESTATION = "AA" - DevSupportInfo.kt: add parseAppAttestationSection() companion function with 5 rows: Attestation Enabled, API Host, Google Cloud Project ID, Integrity Provider Ready, Feature Flag (AA) - SalesforceSDKManager.kt: wire additionalSections.add(parseAppAttestationSection(...)) in devSupportInfo getter alongside the existing RTR section - DevSupportInfoTest.kt: add 7 unit tests covering all field combinations (no client, client without host, client with host/provider not ready, fully configured, and feature flag N/A/false/true)
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } else "N/A" | ||
| val providerReady = when { | ||
| appAttestationClient == null -> "N/A" | ||
| appAttestationClient.integrityTokenProvider != null -> "true" |
There was a problem hiding this comment.
| This method should only be accessed from tests or within private scope |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Features.java: addsFEATURE_APP_ATTESTATION = "AA"constantDevSupportInfo.kt: addsparseAppAttestationSection()companion function with 5 rows:appAttestationClient != null && apiHostName != null)apiHostNameor "N/A")integrityTokenProvider != null→ true/false/N/A)SalesforceSDKManager.kt: wiresadditionalSections.add(parseAppAttestationSection(...))indevSupportInfogetter alongside the RTR sectionTests
Added 7 unit tests in
DevSupportInfoTest.kt:apiHostName→ Attestation Enabled: falseRelated