Moving to SQLCipher 4.10.0 - #7
Merged
Merged
Conversation
wmathurin
commented
Aug 16, 2025
| .binaryTarget( | ||
| name: "MobileSync", | ||
| path:"archives/MobileSync.xcframework.zip" | ||
| ), |
Collaborator
Author
There was a problem hiding this comment.
The wrapper is needed because binary target cannot have dependencies
wmathurin
commented
Aug 16, 2025
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/sqlcipher/SQLCipher.swift.git", exact: "4.10.0"), | ||
| .package(url: "https://github.com/wmathurin/fmdb.git", branch: "spm_with_sqlcipher") |
Collaborator
Author
There was a problem hiding this comment.
NB: will switch that to forcedotcom/fmdb once forcedotcom/fmdb#15 gets merged
wmathurin
commented
Aug 16, 2025
| // Re-export the SmartStore framework | ||
| @_exported import SmartStore | ||
|
|
||
| // Re-export SQLCipher for encryption capabilities |
Collaborator
Author
There was a problem hiding this comment.
We don't really need to re-export SQLCipher and FMDB but that way consuming apps can use those APIs if they wish to.
(Added macCatalyst in platforms)
wmathurin
marked this pull request as ready for review
August 19, 2025 22:05
bbirman
approved these changes
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important, only merge after:
SQLCipher 4.10.0 added support for SPM.
As a result we no longer link it as a static library in SalesforceMobileSDK-iOS.
With the changes below, our Swift package now depends on FMDB/SQLCipher instead of embedding them.