Skip to content

@W-18992574 Updating unit test on web sockets to clean up after each test more #3893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crebs merged 7 commits into from
Jul 25, 2025
Merged

@W-18992574 Updating unit test on web sockets to clean up after each test more #3893

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0f4a4ca
Updating unit test on websockets to clean up after each test more
Crebs Jul 25, 2025
ba51896
Start bisect of flappy Test
Crebs Jul 25, 2025
44dccef
finding the issue of the flapping test
Crebs Jul 25, 2025
7e66862
adding Websocket tests back in
Crebs Jul 25, 2025
2f15125
Bisecting
Crebs Jul 25, 2025
3dba615
Adding test back in to bisect
Crebs Jul 25, 2025
5ad1abd
looking at fulfilled call
Crebs Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 35 additions & 26 deletions libs/SalesforceSDKCore/SalesforceSDKCoreTests/WebSocketClientTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,47 +98,56 @@
}

final class WebSocketClientTests: XCTestCase {
var client: WebSocketClient?
var mockTask: MockWebSocket?

override func tearDown() {
client?.cancel()
client = nil
mockTask = nil
super.tearDown()
}

func testSendMessageSuccess() async {
// Given
let mockTask = MockWebSocket()
let client = WebSocketClient(task: mockTask)
mockTask = MockWebSocket()
client = WebSocketClient(task: mockTask!)
let message = URLSessionWebSocketTask.Message.string("test")

// When
do {
try await client.send(message)
XCTAssertEqual(mockTask.sentMessages.count, 1)
try await client?.send(message)
XCTAssertEqual(mockTask?.sentMessages.count, 1)
} catch {
XCTFail("Shouldn't send message: \(error)")
}
}

func testCancelTask() {
// Given
let mockTask = MockWebSocket()
let client = WebSocketClient(task: mockTask)
mockTask = MockWebSocket()
client = WebSocketClient(task: mockTask!)

// When
client.cancel()
client?.cancel()

// Then
XCTAssertTrue(mockTask.didCancel)
XCTAssertTrue(mockTask?.didCancel ?? false)
}

func testListenReceivesSuccessMessage() {

// Given
let mockTask = MockWebSocket()
let client = WebSocketClient(task: mockTask)
mockTask = MockWebSocket()
client = WebSocketClient(task: mockTask!)
let expectation = self.expectation(description: "Message received")

// When
client.listen { result in
client?.listen { result in
switch result {
case .success(_):
// Then
expectation.fulfill()

Check failure on line 150 in libs/SalesforceSDKCore/SalesforceSDKCoreTests/WebSocketClientTests.swift

View workflow job for this annotation

GitHub Actions / ios-pr (SalesforceSDKCore) / test-ios 

    testRemoveSessionForcefullyCallsCompletion, API violation - multiple calls made to -[XCTestExpectation fulfill] for Message received. (NSInternalInconsistencyException)

Check failure on line 150 in libs/SalesforceSDKCore/SalesforceSDKCoreTests/WebSocketClientTests.swift

View workflow job for this annotation

GitHub Actions / SalesforceSDKCore iOS ^18

Uncaught Exception 

API violation - multiple calls made to -[XCTestExpectation fulfill] for Message received. (NSInternalInconsistencyException)
case .failure(_):
XCTFail("Expected success")
}
Expand All @@ -148,20 +157,20 @@

func testListenReceivesFailureAndPerformRetryToSuccess() {
// Given
let mockTask = MockWebSocket()
mockTask.shouldError.toggle()
mockTask.originalRequest = URLRequest(url: URL(string: "ws://mock.com")!)
mockTask = MockWebSocket()
mockTask?.shouldError.toggle()
mockTask?.originalRequest = URLRequest(url: URL(string: "ws://mock.com")!)
let mockNetwork = MockNetwork()
mockNetwork.mockWebSocket = mockTask
let mockAccountManager = MockUserAccountManager()
let client = WebSocketClient(task: mockTask,
network: mockNetwork,
accountManager: mockAccountManager)
client = WebSocketClient(task: mockTask!,
network: mockNetwork,
accountManager: mockAccountManager)
let expectation = self.expectation(description: "Success received")

// When
client.listen { result in
mockTask.keepReceivingMessages.toggle()
client?.listen { result in
self.mockTask?.keepReceivingMessages.toggle()
switch result {
case .success(let message):
// Then
Expand All @@ -175,20 +184,20 @@

func testListenReceivesFailureAndPerformRetryToFailure() {
// Given
let mockTask = MockWebSocket()
mockTask.shouldError.toggle()
mockTask.originalRequest = URLRequest(url: URL(string: "ws://mock.com")!)
mockTask = MockWebSocket()
mockTask?.shouldError.toggle()
mockTask?.originalRequest = URLRequest(url: URL(string: "ws://mock.com")!)
let mockAccountManager = MockUserAccountManager()
mockAccountManager.shouldError.toggle()
let mockNetwork = MockNetwork()
mockNetwork.shouldError.toggle()
let client = WebSocketClient(task: mockTask,
network: mockNetwork,
accountManager: mockAccountManager)
client = WebSocketClient(task: mockTask!,
network: mockNetwork,
accountManager: mockAccountManager)
let expectation = self.expectation(description: "Error received")

// When
client.listen { result in
client?.listen { result in
switch result {
case .failure(let error):
// Then
Expand Down
Loading