Skip to content

@W-18992574 fixing flapping test on websockets callback #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Crebs merged 3 commits into from
Jul 30, 2025
Merged

@W-18992574 fixing flapping test on websockets callback #3895

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddf55e3
fixing flapping test on websockets callback
Crebs Jul 28, 2025
105bb42
add print statement for case of call happening more than once, but do…
Crebs Jul 29, 2025
67ff65d
Turn off mock task after we mock the message sent
Crebs Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 5 additions & 22 deletions libs/SalesforceSDKCore/SalesforceSDKCoreTests/WebSocketClientTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,6 @@ class MockWebSocket: WebSocketClientTaskProtocol {
completionHandler(nil)
}

func receive(completionHandler: @escaping @Sendable (Result<URLSessionWebSocketTask.Message, any Error>) -> Void) {

guard keepReceivingMessages else { return }

if !shouldError {
completionHandler(.success(URLSessionWebSocketTask.Message.string("incoming")))
} else {
let error = NSError(domain: "test", code: 1, userInfo: nil)
completionHandler(.failure(error))
}
}

func cancel(with closeCode: URLSessionWebSocketTask.CloseCode, reason: Data?) {
didCancel = true
}
Expand Down Expand Up @@ -136,20 +124,19 @@ final class WebSocketClientTests: XCTestCase {
}

func testListenReceivesSuccessMessage() {

// Given
mockTask = MockWebSocket()
client = WebSocketClient(task: mockTask!)
let expectation = self.expectation(description: "Message received")

// When
client?.listen { result in
self.mockTask?.keepReceivingMessages.toggle()
switch result {
case .success(_):
// Then
expectation.fulfill()
case .failure(_):
XCTFail("Expected success")
case .failure(let error):
XCTAssertNotNil(error as? CancellationError)
}
}
wait(for: [expectation], timeout: 5.0)
Expand Down Expand Up @@ -195,18 +182,14 @@ final class WebSocketClientTests: XCTestCase {
network: mockNetwork,
accountManager: mockAccountManager)
let expectation = self.expectation(description: "Error received")
var fulfilled = false


// When
client?.listen { result in
switch result {
case .failure(let error):
// Then
XCTAssertNotNil(error)
if !fulfilled {
fulfilled = true
expectation.fulfill()
}
expectation.fulfill()
default:
XCTFail("Expected Failure")
}
Expand Down
Loading