Skip to content

@W-19071305 Fix enum comparison warnings in SFUserAccountManager - #3896

Merged
Crebs merged 1 commit into
forcedotcom:devfrom
Crebs:@W-19071305
Aug 6, 2025
Merged

@W-19071305 Fix enum comparison warnings in SFUserAccountManager#3896
Crebs merged 1 commit into
forcedotcom:devfrom
Crebs:@W-19071305

Conversation

@Crebs

@Crebs Crebs commented Aug 5, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Aug 5, 2025

Copy link
Copy Markdown
1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFUserAccountManager Unlocalizable string Localizability Issue (Apple) User-facing text should use localized string macro 929 40
SFUserAccountManager Nullability Memory error Null passed to a callee that requires a non-null 2nd parameter 1472 15
SFUserAccountManager Nullability Memory error Null passed to a callee that requires a non-null 2nd parameter 1487 15
SFUserAccountManager Nullability Memory error nil passed to a callee that requires a non-null 2nd parameter 2119 13

Generated by 🚫 Danger

@codecov

codecov Bot commented Aug 5, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.57%. Comparing base (d224ae7) to head (b3bc348).
⚠️ Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3896      +/-   ##
==========================================
+ Coverage   62.45%   62.57%   +0.11%     
==========================================
  Files         249      249              
  Lines       22371    22371              
==========================================
+ Hits        13972    13998      +26     
+ Misses       8399     8373      -26     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 70.58% <ø> (ø)
Core 52.38% <100.00%> (+0.21%) ⬆️
SmartStore 73.66% <ø> (ø)
MobileSync 87.66% <ø> (-0.11%) ⬇️
Files with missing lines Coverage Δ
...SDKCore/Classes/UserAccount/SFUserAccountManager.m 36.52% <100.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Crebs
Crebs merged commit 1bd2710 into forcedotcom:dev Aug 6, 2025
21 of 22 checks passed
@Crebs
Crebs deleted the @W-19071305 branch August 6, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants