Add welcome discovery flag instead of having hardcoded consumer keys - #3945
Merged
Conversation
Clang Static Analysis Issues
Generated by 🚫 Danger |
wmathurin
reviewed
Oct 23, 2025
wmathurin
left a comment
Contributor
There was a problem hiding this comment.
Should it something like be canUseWelcomeDiscovery or supportsWelcomeDiscovery?
Setting the flag to true will only cause a welcome discovery flow to take place if the login server is also the discovery one.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #3945 +/- ##
==========================================
- Coverage 63.05% 62.18% -0.88%
==========================================
Files 249 249
Lines 22455 22462 +7
==========================================
- Hits 14160 13967 -193
- Misses 8295 8495 +200
🚀 New features to boost your workflow:
|
wmathurin
approved these changes
Oct 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.