Skip to content

Add welcome discovery flag instead of having hardcoded consumer keys - #3945

Merged
bbirman merged 3 commits into
forcedotcom:devfrom
bbirman:welcome-flag
Oct 23, 2025
Merged

Add welcome discovery flag instead of having hardcoded consumer keys#3945
bbirman merged 3 commits into
forcedotcom:devfrom
bbirman:welcome-flag

Conversation

@bbirman

@bbirman bbirman commented Oct 23, 2025

Copy link
Copy Markdown
Member

No description provided.

@github-actions

Copy link
Copy Markdown
1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFOAuthCoordinator Nullability Memory error nil assigned to a pointer which is expected to have non-null value 120 19
SFOAuthCoordinator Nullability Memory error nil assigned to a pointer which is expected to have non-null value 370 15
SFOAuthCoordinator Nullability Memory error nil assigned to a pointer which is expected to have non-null value 380 15
SalesforceSDKManager Nil value used as mutex for @synchronized() (no synchronization will occur) Logic error Nil value used as mutex for @synchronized() (no synchronization will occur) 144 5
SalesforceSDKManager Nil value used as mutex for @synchronized() (no synchronization will occur) Logic error Nil value used as mutex for @synchronized() (no synchronization will occur) 156 5

Generated by 🚫 Danger

@wmathurin wmathurin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it something like be canUseWelcomeDiscovery or supportsWelcomeDiscovery?
Setting the flag to true will only cause a welcome discovery flow to take place if the login server is also the discovery one.

@codecov

codecov Bot commented Oct 23, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.18%. Comparing base (f71eda5) to head (cb646bf).
⚠️ Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
...ore/Classes/OAuth/DomainDiscoveryCoordinator.swift 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3945      +/-   ##
==========================================
- Coverage   63.05%   62.18%   -0.88%     
==========================================
  Files         249      249              
  Lines       22455    22462       +7     
==========================================
- Hits        14160    13967     -193     
- Misses       8295     8495     +200     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 71.44% <ø> (+0.34%) ⬆️
Core 51.74% <75.00%> (-1.42%) ⬇️
SmartStore 73.66% <ø> (ø)
MobileSync 87.76% <ø> (ø)
Files with missing lines Coverage Δ
...forceSDKCore/Classes/Common/SalesforceSDKManager.m 57.03% <100.00%> (-0.68%) ⬇️
...lesforceSDKCore/Classes/OAuth/SFOAuthCoordinator.m 42.30% <100.00%> (+0.06%) ⬆️
...ore/Classes/OAuth/DomainDiscoveryCoordinator.swift 86.53% <85.71%> (-3.47%) ⬇️

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bbirman
bbirman merged commit 12143c2 into forcedotcom:dev Oct 23, 2025
20 of 24 checks passed
@bbirman
bbirman deleted the welcome-flag branch October 23, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants