feat(telemetry): add A1-A5/TM/JT/OT/BN per-user feature flag markers (W-23762052) - #4125
Open
wmathurin wants to merge 9 commits into
Open
feat(telemetry): add A1-A5/TM/JT/OT/BN per-user feature flag markers (W-23762052)#4125wmathurin wants to merge 9 commits into
wmathurin wants to merge 9 commits into
Conversation
Clang Static Analysis Issues
Generated by 🚫 Danger |
…(W-23762052) Add aMarkerFor() helper in BaseAuthFlowTester that computes A1–A4 from useWebServerFlow/useHybridFlow. Thread expectedAMarker through validate(), restartAndValidateUser(), switchToUserAndValidateUser(), migrateAndValidate(), and the public assertRevokeAndRefreshWorks() overload. Add wasMigrated:true on all migrateAndValidate() paths. Update RTRLoginTests and DPoPLoginTests to pass useHybridFlow:false where the test uses a non-hybrid flow so the revoke/refresh cycle asserts A3 instead of A2. Update direct validateUserAgent calls in MultiUserLoginTests with the correct A2 marker.
|
||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your patch check has failed because the patch coverage (36.73%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #4125 +/- ##
==========================================
+ Coverage 67.17% 71.46% +4.28%
==========================================
Files 254 254
Lines 22570 22619 +49
==========================================
+ Hits 15162 16164 +1002
+ Misses 7408 6455 -953
🚀 New features to boost your workflow:
|
…23762052) AppConfig gains isBeacon (hasPrefix "beacon_") matching the existing issuesJwt/isRtr/isDPoP pattern. The private validate() helper now derives isBeacon from userAppConfig and passes it to validateUser(), so beacon tests assert BN is present without requiring per-callsite changes.
… (W-23762052) Both overloads of assertRevokeAndRefreshWorks were omitting isJwt and isBeacon, causing the post-revoke/refresh validateUserAgent call to default both to false. This caused false failures on beacon and JWT apps (BN or JT present in UA but test expected absent).
Add three tests whose users intentionally carry diverging A-markers and companion flags (OT/JT, BN, TM) so that per-user flag leakage is detectable. All previous multi-user tests shared A2 for both users, making such leakage invisible. - testFlagDiversity_A1OtVsA2Jt (MultiUserLoginTests): A1+OT vs A2+JT - testFlagDiversity_A1JtBnVsA2OtNoBn (MultiUserLoginTests): A1+JT+BN vs A2+OT - testFlagDiversity_TmJtBnVsA1OtNoTm (RefreshTokenMigrationTests): post-migration A2+TM+JT+BN vs fresh A1+OT
…(W-23762052) - MultiUserLoginTests: 11 → 13 tests; add A-marker isolation note and two new rows in the test table - RefreshTokenMigrationTests: 11 → 12 tests; add testFlagDiversity_TmJtBnVsA1OtNoTm row
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
…names (W-23762052)
…ginWithRestartTests restartAndValidateUser and switchToUserAndValidateUser both called validateUser without deriving isBeacon from the app config, so the BN flag check always defaulted to isBeacon: false. Look up the app config in each helper and forward isBeacon: userAppConfig.isBeacon to validateUser, matching the pattern already used in validate().
…r A-marker (W-23762052) - Merged upstream/dev: AA flag now preserved on token refresh (W-23616382), AA promotion moved inside completedAuthType != SFOAuthTypeRefresh guard - Resolved conflicts in SFUserAccountManager.m and SFSDKAppFeatureMarkersTests.m: kept A/TM/JT/OT/BN blocks; integrated new AA tests from upstream - Added AdvancedBrowser A-marker: native browser flow always uses web-server grant, so SFOAuthTypeAdvancedBrowser now registers A1/A2 (fixes LoginForAdmin UI test failure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GUS story
W-23762052: https://gus.my.salesforce.com/lightning/r/ADM_Work__c/a07EE00002grYFgYAM/view
Test plan