This repository was archived by the owner on Jul 2, 2026. It is now read-only.
[W-19111839] refactor: use fs.writeFile() instead of textEditor.setText() to populate file contents - #82
Merged
Conversation
…th no custom text
…folder where the Apex class needs to be created
…4)' warning in extensionUtils.ts
…visualforceUtils.ts and apexUtils.ts
…ndValidateCommand()
…in overrideTextInFile()
…se it is no longer needed
daphne-sfdc
commented
Jul 31, 2025
| const metadataPaths: Record<string, string> = { | ||
| ApexClass: `force-app${pathSeparator}main${pathSeparator}default${pathSeparator}classes`, | ||
| ExternalServiceRsegistration: `force-app${pathSeparator}main${pathSeparator}default${pathSeparator}externalServiceRegistrations`, | ||
| ExternalServiceRegistration: `force-app${pathSeparator}main${pathSeparator}default${pathSeparator}externalServiceRegistrations`, |
Contributor
Author
There was a problem hiding this comment.
Found this typo - how had this been working before?
Contributor
There was a problem hiding this comment.
That's weird. Good catch!
daphne-sfdc
commented
Jul 31, 2025
| /** | ||
| * Shows the list of running extensions in VS Code | ||
| * @returns {Promise<Editor | undefined>} The editor showing running extensions, or undefined if not found | ||
| * @returns The editor showing running extensions, or undefined if not found |
Contributor
Author
There was a problem hiding this comment.
I was getting a JSDoc types may be moved to TypeScript types. ts(80004) warning on this file, and this was the suggested solution. I did notice that all new JSDocs were created without any types listed.
daphne-sfdc
marked this pull request as ready for review
August 1, 2025 01:52
CristiCanizales
previously approved these changes
Aug 1, 2025
CristiCanizales
left a comment
CristiCanizales
left a comment
Contributor
There was a problem hiding this comment.
Thank you for working on this Daphne! 🥳
🚢
| const metadataPaths: Record<string, string> = { | ||
| ApexClass: `force-app${pathSeparator}main${pathSeparator}default${pathSeparator}classes`, | ||
| ExternalServiceRsegistration: `force-app${pathSeparator}main${pathSeparator}default${pathSeparator}externalServiceRegistrations`, | ||
| ExternalServiceRegistration: `force-app${pathSeparator}main${pathSeparator}default${pathSeparator}externalServiceRegistrations`, |
Contributor
There was a problem hiding this comment.
That's weird. Good catch!
daphne-sfdc
dismissed
CristiCanizales’s stale review
August 1, 2025 20:26
Files have changed since the last review.
CristiCanizales
approved these changes
Aug 4, 2025
CristiCanizales
left a comment
CristiCanizales
left a comment
Contributor
There was a problem hiding this comment.
Just a NIT. Thanks Daphne!
| import { getBrowser } from './workbench'; | ||
| import { retryOperation } from '../retryUtils'; | ||
| import fs from 'fs'; | ||
| import * as fs from 'node:fs/promises'; |
Contributor
There was a problem hiding this comment.
I see in visualforceUtils.ts we're importing just 'fs/promises', I know it's the same but let's just use the same style for consistency!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates our E2E tests to enhance reliability by switching from
textEditor.setText()andtextEditor.setTextAtLine()tofs.writeFile()for populating file contents.Previously, our E2E tests would open files in an Editor View and use UI-based methods to replace their contents. This approach proved unreliable and led to flappers. These failures were due to the inherent instability of UI-driven file manipulation within the testing environment.
By adopting
fs.writeFile(), we now directly interact with the filesystem to create or overwrite file contents. This change significantly improves the stability of our E2E tests, as it bypasses the less predictable UI operations. Our primary goal for these E2E tests is not to test file creation – that's already covered in our templates.e2e.ts – but rather to validate broader system functionality.This refactor ensures our E2E tests are more robust and less prone to environmental inconsistencies, allowing us to focus on testing the core features they were designed for.