Port to GNOME Shell 49#473
Merged
Merged
Conversation
- Replace `Meta.Window.get_maximized()` with `Meta.Window.is_maximized()`. - Update `Meta.Window.unmaximize()` calls. https://gjs.guide/extensions/upgrading/gnome-shell-49.html#meta-window
Changes are not backward compatible.
juarezr
requested changes
Sep 15, 2025
juarezr
left a comment
juarezr
left a comment
Contributor
There was a problem hiding this comment.
Can we maintain compatibility with versions before 49?
- This way, users with LTC distros will stay covered. These distros don't update in sync with each Gnome release.
- It also helps to update the extension while using Gnome 48.
juarezr
approved these changes
Sep 16, 2025
juarezr
left a comment
juarezr
left a comment
Contributor
There was a problem hiding this comment.
I have tested and didn't find any problem.
Right now, I'm running the version built from this PR.
Contributor
|
The CI is complaining about formatting issues in npm run format |
jmmaranan
approved these changes
Sep 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.