Fix include regex to support slash in paths#523
Open
Ayushishivhare09 wants to merge 3 commits intofortran-lang:masterfrom
Open
Fix include regex to support slash in paths#523Ayushishivhare09 wants to merge 3 commits intofortran-lang:masterfrom
Ayushishivhare09 wants to merge 3 commits intofortran-lang:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #523 +/- ##
=======================================
Coverage 44.43% 44.43%
=======================================
Files 35 35
Lines 4803 4803
=======================================
Hits 2134 2134
Misses 2669 2669 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Hi @gnikit, Just a gentle follow-up on this PR As the GSoC 2026 proposal deadline is approaching, I would really appreciate a review whenever you have a moment. Thanks for your time and guidance — looking forward to your feedback! |
150ab8d to
da69164
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix include regex to support paths with slashes
Problem
The regex for parsing
#includestatements does not correctly capture paths containing/.Example:
#include "petsc/finclude/petscvec.h"
was parsed as:
petsc
Solution
Updated regex to include
/in the captured path.Changes
regex_patterns.pyFixes #481