Skip to content

composer: fix warning#1119

Merged
jtojnar merged 1 commit into
fossar:masterfrom
StyXman:patch-1
Aug 7, 2019
Merged

composer: fix warning#1119
jtojnar merged 1 commit into
fossar:masterfrom
StyXman:patch-1

Conversation

@StyXman

@StyXman StyXman commented Jul 29, 2019

Copy link
Copy Markdown
Contributor

Fixes #1118

@jtojnar

jtojnar commented Jul 30, 2019

Copy link
Copy Markdown
Member

Thank you for the pull request. We are soon going to merge #1096, which removes CSSMin, making this issue moot.

Also note that when you update composer.json it is a good practice to run composer update --lock to propagate the changes to the composer.lock file.

@StyXman

StyXman commented Jul 30, 2019

Copy link
Copy Markdown
Contributor Author

when you update composer.json it is a good practice to run composer update --lock to propagate the changes to the composer.lock file.

Heh, I didn't know, sorry, I'm far from being a PHP dev. Closing, then...

@StyXman StyXman closed this Jul 30, 2019
@jtojnar jtojnar reopened this Aug 7, 2019
@jtojnar jtojnar added this to the 2.19 milestone Aug 7, 2019
@jtojnar jtojnar changed the title Fix #1118. composer: fix warning Aug 7, 2019
@jtojnar

jtojnar commented Aug 7, 2019

Copy link
Copy Markdown
Member

I guess we can merge it in the meanwhile. Thanks for the PR.

@jtojnar jtojnar merged commit 158c90d into fossar:master Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecated Camelcase package names for compose

2 participants