client: Avoid off-line mode instrumentation when off-line mode is not enabled#1361
Merged
Conversation
At least not until submitted – only use it for default checkbox value. It also was not even updating the `selfoss.db.enableOffline` anyway leading to a inconsistent state.
Not as useful as it once would have been since we already moved majority of those into App.
Whether user is logged in already checked by the selfoss methods.
The service worker would trigger an annoying update notification all the time. Also make the init functions async, clean up them a bit and add comments.
Might be somewhat annoying when the “log out” button is clicked accidentally but it is generally expected that on log out all session data will be cleared. Maybe we can hide the button into a submenu in the future. Also make the `logout` function async and re-organize it a bit (redirect only after user has been logged out).
And use the definition from rooks.
jtojnar
force-pushed
the
sw-only-offline
branch
from
4dd1c3d to
9d2de77
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.