Conversation
jtojnar
commented
Apr 14, 2017
jtojnar
force-pushed
the
refactor
branch
5 times, most recently
from
6dccd93 to
63d2408
Compare
jtojnar
force-pushed
the
refactor
branch
2 times, most recently
from
f5da4a5 to
d6c0d9d
Compare
jtojnar
force-pushed
the
refactor
branch
2 times, most recently
from
f145a6b to
0ec02ab
Compare
Member
Author
|
For some reason https://feeds.feedburner.com/sandraandwoo now uses feedburner favicon instead of the site one. Hopefully, this will be addressed by a rewrite of |
Collaborator
|
Yes this happens since merging #920 . |
Member
Author
|
You are right, I was probably using old master on my selfoss instance. For now, I have reverted one of the commits, see #924. |
jtojnar
force-pushed
the
refactor
branch
2 times, most recently
from
fb325ea to
1afe4d6
Compare
jtojnar
force-pushed
the
refactor
branch
4 times, most recently
from
3e07bae to
986f814
Compare
jtojnar
force-pushed
the
refactor
branch
3 times, most recently
from
a6bd0d1 to
cc64077
Compare
jtojnar
force-pushed
the
refactor
branch
2 times, most recently
from
883e795 to
47f251b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been trying to use
nullinstead offalseor''whenever possible. Additionally, I also changed majority of comparisons to strict version, filled in missing parameters to phpdoc and also addedarraytype hints.Tests should be merged first.