Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

Fix-408 Using materialistic alerts#495

Open
championpaddler wants to merge 2 commits into
fossasia:masterfrom
championpaddler:Fix-408
Open

Fix-408 Using materialistic alerts#495
championpaddler wants to merge 2 commits into
fossasia:masterfrom
championpaddler:Fix-408

Conversation

@championpaddler

Copy link
Copy Markdown
Member

Fixes #408

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

screenshot from 2018-12-05 21-36-55

Changes proposed in this pull request:

-Using materialistic alerts.

@championpaddler

Copy link
Copy Markdown
Member Author

@fossasia/susi-ai @mariobehling Please review.

Comment thread src/css/notifications.min.css
Comment thread src/options.html Outdated
Comment thread src/options.html Outdated
@championpaddler

Copy link
Copy Markdown
Member Author

@zamhaq Please review.

@fossasia fossasia deleted a comment Dec 7, 2018
@fossasia fossasia deleted a comment Dec 7, 2018
@fossasia fossasia deleted a comment from rajvaibhavdubey Dec 7, 2018
@fossasia fossasia deleted a comment Dec 7, 2018
@fossasia fossasia deleted a comment Dec 7, 2018
@fossasia fossasia deleted a comment from rajvaibhavdubey Dec 7, 2018
@fossasia fossasia deleted a comment from rajvaibhavdubey Dec 7, 2018
@fossasia fossasia deleted a comment Dec 7, 2018
@fossasia fossasia deleted a comment Dec 7, 2018
@fossasia fossasia deleted a comment from rajvaibhavdubey Dec 7, 2018
@fossasia fossasia deleted a comment from rajvaibhavdubey Dec 7, 2018
@fossasia fossasia deleted a comment from rajvaibhavdubey Dec 7, 2018
@fossasia fossasia deleted a comment Dec 7, 2018
@fossasia fossasia deleted a comment Dec 7, 2018
@fossasia fossasia deleted a comment from rajvaibhavdubey Dec 7, 2018
@fossasia fossasia deleted a comment Dec 7, 2018
@fossasia fossasia deleted a comment from rajvaibhavdubey Dec 7, 2018
@fossasia fossasia deleted a comment from rajvaibhavdubey Dec 7, 2018
@championpaddler

Copy link
Copy Markdown
Member Author

@mariobehling @ms10398 @fossasia/susi-ai Please review

@championpaddler

Copy link
Copy Markdown
Member Author

@hkedia321 @techpool Please approve.

@championpaddler

Copy link
Copy Markdown
Member Author

@zamhaq Please review and merge this.

@championpaddler

Copy link
Copy Markdown
Member Author

@gabru-md @DNS-404 Please review.

@fragm3 fragm3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline review @sk9331657

Comment thread src/js/options.js Outdated
}, (stream) => {
stream.getTracks().forEach(track => track.stop());
displayNotification("success", " Mic Access Granted", 1000);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra line

Comment thread src/js/options.js Outdated
}, () => {
console.log("no access");
displayNotification("error", " No Access", 1000);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra line

Comment thread src/js/options.js Outdated
displayNotification("error", " No Access", 1000);

});

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove extra line

Comment thread src/js/options.js Outdated
localStorage.setItem("theme",theme);
alert("Success");
});
displayNotification("info", "Theme successfully changed", 1000);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the file properly

Comment thread src/js/options.js Outdated

});
displayNotification("warning", " Restored Settings", 1000);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@championpaddler championpaddler force-pushed the Fix-408 branch 3 times, most recently from 0c22512 to 1b5812e Compare January 23, 2019 05:17
@championpaddler

Copy link
Copy Markdown
Member Author

@fragm3 Resolved Issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using Materialistic Alerts instead of document alert for notifying users

4 participants