Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

Pull Request Template Updated#502

Open
neeraj3029 wants to merge 4 commits into
fossasia:masterfrom
neeraj3029:updatetemplate
Open

Pull Request Template Updated#502
neeraj3029 wants to merge 4 commits into
fossasia:masterfrom
neeraj3029:updatetemplate

Conversation

@neeraj3029

Copy link
Copy Markdown
Member

Fixes #498

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Pull Request now asks for Screenshots and is more descriptive now.

Changes proposed in this pull request:

Pull Request now asks for Screenshots and is more descriptive now.

<!-- Add the issue number that is fixed by this PR (In the form Fixes #123) -->

Fixes #
[Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed as already at line 4 description about it is given. You can edit that.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both lines have different meanings, please see carefully.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I am saying that please edit at line 4 to merge both information. As both are related to issue number.

@championpaddler championpaddler left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neeraj3029 Squash Your Commits/

@fragm3 fragm3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash your commits

@neeraj3029

Copy link
Copy Markdown
Member Author

@samagragupta Please review

@samagragupta

Copy link
Copy Markdown
Member

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pull Request template needs changes

4 participants