Skip to content
This repository was archived by the owner on May 21, 2026. It is now read-only.

signup: new UI for signup page#524

Open
ambujraj wants to merge 2 commits into
fossasia:masterfrom
ambujraj:master
Open

signup: new UI for signup page#524
ambujraj wants to merge 2 commits into
fossasia:masterfrom
ambujraj:master

Conversation

@ambujraj

@ambujraj ambujraj commented Jan 12, 2019

Copy link
Copy Markdown
Member

Fixes #521

Checklist

  • I have read the Contribution & Best practices Guide and my PR follows them.
  • My branch is up-to-date with the Upstream master branch.
  • The unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

The signup UI should look more attractive.

Changes proposed in this pull request:

  • Changes the UI design for better look and more attractive.

Screenshot of the change

d

@samagragupta samagragupta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide padding between email and password text field.

@ambujraj

Copy link
Copy Markdown
Member Author

@samagragupta done.

@samagragupta samagragupta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just squash the commits.

@ambujraj

ambujraj commented Jan 15, 2019

Copy link
Copy Markdown
Member Author

done @samagragupta

@ambujraj

Copy link
Copy Markdown
Member Author

@samagragupta can you please reply if any changes is required

@fragm3 fragm3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove bootstrap.min.js changes, avoid adding extra new lines

@ambujraj

Copy link
Copy Markdown
Member Author

@fragm3 I didn't get you. Can you please elaborate

@fragm3

fragm3 commented Feb 4, 2019

Copy link
Copy Markdown
Contributor

@ambujraj bootstrap.min.css changes are not needed remove them

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Signup UI design need to improve

5 participants