Add missing type stubs for newer visualization methods - #1418
Merged
Conversation
Contributor
Reviewer's GuideAdds missing type stubs in py/visdom/init.pyi for four existing Visdom visualization methods so that the stub file matches the implementation and supports better static typing and IDE features. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Manik-Khajuria-5
approved these changes
Jun 11, 2026
Manik-Khajuria-5
requested review from
Jayantparashar10,
Saksham-Sirohi,
rajnisht7,
tonypzy and
vedansh-5
June 14, 2026 08:50
rajnisht7
suggested changes
Jul 5, 2026
rajnisht7
left a comment
Contributor
There was a problem hiding this comment.
@Debajeet-1411 changes looks good, just resolve the conflicts
tonypzy
approved these changes
Jul 5, 2026
Jayantparashar10
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing declarations to
py/visdom/__init__.pyifor public methods already implemented in theVisdomclass:sunburst()dual_axis_lines()properties()embeddings()Motivation
The implementation and type stub files are currently out of sync, which can result in incomplete IDE autocomplete suggestions and inaccurate static analysis for users relying on type information.
Changes
Added the corresponding method signatures to the
Visdomclass stub in__init__.pyi.Impact
Summary by Sourcery
Add missing type stub declarations for additional Visdom visualization methods to keep stubs in sync with the implementation.
New Features:
Enhancements: