feat: Integrate Playwright E2E testing infrastructure - #1541
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sorry @vedansh-5, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
There was a problem hiding this comment.
Pull request overview
This pull request introduces an initial Playwright-based E2E testing setup for Visdom (alongside the existing Cypress suite), including a basic smoke-test suite, Playwright configuration, CI wiring, and contributor documentation updates.
Changes:
- Add Playwright test runner configuration and a starter E2E test spec.
- Wire a new Playwright job into the existing PR CI workflow and expose an npm script to run it.
- Update contributor docs/README to document running both Cypress and Playwright tests.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
yarn.lock |
Adds Playwright packages and updates the dependency lock (also reflects a sizable Cypress dependency reshuffle). |
package.json |
Adds @playwright/test and a test:pw script to run Playwright. |
playwright.config.js |
Introduces Playwright test configuration (baseURL, retries, reporter, project). |
playwright/tests/basic.spec.js |
Adds initial smoke/E2E coverage for basic UI availability and env selection. |
playwright/support/helpers.js |
Adds helper utilities intended for driving demo/env flows in Playwright tests. |
.github/workflows/process-changes.yml |
Adds a new CI job to install Playwright Chromium, start Visdom, and run Playwright tests. |
CONTRIBUTING.md |
Documents how to install and run Playwright E2E tests locally. |
README.md |
Updates the contributing blurb to mention both Cypress and Playwright E2E/visual testing. |
Manik-Khajuria-5
left a comment
Manik-Khajuria-5
left a comment
There was a problem hiding this comment.
@vedansh-5 I went through the code most of things are implemneted properly but in ci server is started in a separate CI step from the tests I think they must be in single step as there are certain times when server hanging situation happens or what if server did not survive at all or there might be another approach please verify it once as I am also not too sure about it !
Thanks for pointing this out, I have addressed and pushed these changes. |
|
@Manik-Khajuria-5 Please take a look at the changes. |
Manik-Khajuria-5
left a comment
Manik-Khajuria-5
left a comment
There was a problem hiding this comment.
@vedansh-5 LGTM! adding in config section is a good choice nice work
|
@Saksham-Sirohi @mariobehling This is ready to be merged, Ptal |
Description
This Pull Request introduces the base Playwright E2E testing infrastructure to Visdom. As planned, Cypress and its dependencies remain fully intact while both test suites coexist in this transitional phase.
Motivation and Context
Cypress has been prone to flakiness and slower execution speeds. This initial PR establishes the framework and layout for Playwright E2E and visual testing, allowing subsequent PRs to migrate the remaining suites.
How Has This Been Tested?
Tested locally
Screenshots (if appropriate):
Types of changes
Checklist:
py/visdom/VERSIONaccording to Semantic Versioning